[PATCH 3/3] nvme: add KConfig options for debug features

Sagi Grimberg sagi at grimberg.me
Sun Dec 12 01:22:17 PST 2021


> From: Chaitanya Kulkarni <kch at nvidia.com>
> 
> Add KConfig menu option to enable and disable gencounter debug
> feature that uses config NVME_DEBUG_USE_CID_GENCTR.
> 
> Signed-off-by: Chaitanya Kulkarni <kch at nvidia.com>
> ---
>   drivers/nvme/host/Kconfig | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/nvme/host/Kconfig b/drivers/nvme/host/Kconfig
> index dc0450ca23a3..dfa2609b7006 100644
> --- a/drivers/nvme/host/Kconfig
> +++ b/drivers/nvme/host/Kconfig
> @@ -1,4 +1,14 @@
>   # SPDX-License-Identifier: GPL-2.0-only
> +menu "Debug (Enable driver debug features)"
> +config NVME_DEBUG_USE_CID_GENCTR
> +	bool "Enable command ID gen counter for spurious request completion"
> +	depends on NVME_CORE
> +	help
> +	  The NVM Express driver will use generation conunter
> +	  when calculating the command id. This is needed to debug the
> +	  spurious request completions coming from a buggy controller.

This is not just to debug - it is also to protect against such a
controller. What is the purpose of this config option anyways?
The main distributions will (as they should) enable it anyways...



More information about the Linux-nvme mailing list