[PATCH 1/1] nvme: Add verbose error logging

[Martin K. Petersen]

Hi Chaitanya!

> Although I always prefer descriptive error messages, I've not seen even
> half of these errors in the field. This will :-
>
> 1. Increase the size of the driver code.
> 2. Require constant patching of the driver code when spec is updated,
>    I'm afraid this will turn into churn.

Updating the corresponding list in SCSI hasn't been a big problem.

> Also, we can easily track down the error in the NVMe spec from the
> error code that driver is printing currently, is that not sufficient ?

Only the block layer status is captured.

In addition, customers are not really armed with the NVMe error decoder
ring and are left with no explanation as to why an I/O failed. We have
had good results in the field with the verbose SCSI error logging and
that's why this patch was modeled to work the same way.

-- 
Martin K. Petersen	Oracle Linux Engineering