[PATCH] nvme-cli: remove default ctrl_loss_tmo for connect

[Chaitanya Kulkarni]

On 10/23/20 14:16, Sagi Grimberg wrote:
>> diff --git a/fabrics.c b/fabrics.c
>> index f8a055b..9c33c02 100644
>> --- a/fabrics.c
>> +++ b/fabrics.c
>> @@ -896,8 +896,6 @@ static int build_options(char *argstr, int max_len, bool discover)
>>   				cfg.keep_alive_tmo, false)) ||
>>   	    add_int_argument(&argstr, &max_len, "reconnect_delay",
>>   				cfg.reconnect_delay, false) ||
>> -	    add_int_argument(&argstr, &max_len, "ctrl_loss_tmo",
>> -				cfg.ctrl_loss_tmo, true) ||
> You just removed the entire option altogether? the user can no longer
> pass ctrl_loss_tmo now. You should instead disallow zero back (i.e.
> revert the offending patch that made it as such) and figure out
> a proper way to allow ctrl_loss_tmo=0 functionality.
>
Thanks for the comments will send out the V2.