On 30/11/2020 04:32, Chaitanya Kulkarni wrote: > + ret = __bio_iov_append_get_pages(bio, &from); Can't you just use bio_iov_iter_get_pages() here? It does have a if (WARN_ON_ONCE(is_bvec)) return -EINVAL; in it but I think that can be deleted.