[PATCH v4 02/19] blkcg: Added a app identifier support for blkcg

[Muneendra Kumar M]

Hi Hannes,
Thanks for the review.

> +		ret = -EINVAL;
> +		goto out_put;
> +	}
> +	strlcpy(blkcg->fc_app_id, buf, len);

>String or UUID?
>And will it be NULL-terminated?
>Wouldn't it be better to use 'memcpy' here?
>And it is NULL terminated: what happens if the user sets a 128-byte string?
>IE shouldn't the app_id be 129 bytes long if it's assumed to be
>NULL-terminated?
[Muneendra]It is a string and it is NULL terminated.
Agreed it should be 129 bytes long.

Regards,
Muneendra.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4177 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.infradead.org/pipermail/linux-nvme/attachments/20201118/be8f7fcc/attachment.p7s>