[PATCH] nvme: Boot as soon as the boot controller has been probed

Keith Busch kbusch at kernel.org
Mon Nov 9 22:12:27 EST 2020


On Mon, Nov 09, 2020 at 06:51:48PM -0800, Bart Van Assche wrote:
> On 11/9/20 7:05 AM, Keith Busch wrote:
> > Resets can happen at any time, so user space should always have been
> > prepared for this. Is there actually a real case that is not working for
> > you?
> 
> Hi Keith,
> 
> The use case of running nvme-cli from inside a udev rule is not
> important to me personally. But reducing the boot time for systems with
> multiple NVMe controllers matters to me. Do you want to recommend an
> approach or do you perhaps expect me to explore the possible
> alternatives further?

I only mentioned the changelog doesn't require a fixes tag. I generally
don't have a problem with the patch if it really does improve boot
times, but I'd like to personally try it out through a few scenarios
first. I should be able to complete that this week.

The only comments on the code I have are that you can call
nvme_reset_ctrl_sync() instead of duplicating that, and you also need to
flush the scan_work after to ensure the boot namespace is available when
probe returns.



More information about the Linux-nvme mailing list