[PATCH] nvme: revert commit 1293477f4f32 as it is breaking BLKROSET

Sagi Grimberg sagi at grimberg.me
Mon Nov 9 05:29:37 EST 2020


>>> Just dropping the else part is probably enough for now, although
>>> as a follow on we should probably add a "hard read-only" state to
>>> the block layer.
>>
>> Removing the else would have an incorrect behavior. I think its better
>> to not support it (until we support it correctly) than to support it
>> incorrectly.
> 
> I strongly disagree.  When we see a write protected namespaces doing a
> set_disk_ro is the right thing to do to prevent folks from writing to
> it and getting bogged up in tons of warnings.   I think that use case
> is much more important than the corner case of clearing it later.

OK, I can send a v2 removing the clear.



More information about the Linux-nvme mailing list