[PATCH] nvme: revert commit 1293477f4f32 as it is breaking BLKROSET

Sagi Grimberg sagi at grimberg.me
Fri Nov 6 14:52:21 EST 2020


>>>> The offending commit breaks BLKROSET ioctl because a device
>>>> revalidation will blindly override BLKROSET setting.
>>>>
>>>> The author should resubmit this commit in a way that does
>>>> not break BLKROSET.
>>> Let's fix this properly instead of a blind revert.
>>
>> I've asked Chaitanya to address this, but I guess he didn't
>> get to it so at the very least lets not keep the breakage.
> 
> Yes it is on the list. I am really sorry I got busy with blocktrace [1] 
> work for last couple of weeks.

Not a problem at all really, we are all busy.

> Sagi, I am okay if you want to fix this. Otherwise I'll try and get this 
> and the target side fix next week for sure.

There is no target side fix here, it's just the host that needs fixing.

Still I think this needs to be reverted first and pulled into stable and
re-added correctly. I'm waiting to hear Christoph's opinion here.



More information about the Linux-nvme mailing list