[PATCH v3] nvme: fix identify error status silent ignore

[Sagi Grimberg]

>> Patch 59c7c3caaaf8 intended to only silently ignore
>> non retry-able errors (DNR bit set) such that we can still
>> identify misbehaving controllers, and in the other hand
>> propagate retry-able errors (DNR bit cleared) so we don't
>> wrongly abandon a namespace just because it happens to be
>> temporarily inaccessible.
>>
>> The goal remains the same as the original commit where this
>> was introduced but unfortunately had the logic backwards.
> 
> So how did this work all the time?  I'm really worried that someone
> this is actually going to break things.  What do you think about
> only queueing it up for 5.9 for now?

The code is broken now, the original patch was a mistake. It didn't
fix the scan/error-recovery race, but also broke the ignore we had
for pci. So I think this should go to 5.8-rc and also be picked up
for stable 5.7.