[PATCH 1/3] nvme-tcp: have queue prod/cons send list become a llist

Christoph Hellwig hch at lst.de
Wed Jun 24 12:48:57 EDT 2020


On Thu, Jun 18, 2020 at 05:30:22PM -0700, Sagi Grimberg wrote:
> +static void nvme_tcp_process_req_list(struct nvme_tcp_queue *queue)
> +{
> +	struct nvme_tcp_request *req;
> +	struct llist_node *node;
> +
> +	node = llist_del_all(&queue->req_list);
> +	if (!node)
> +		return;
> +
> +	while (node) {
> +		req = llist_entry(node, struct nvme_tcp_request, lentry);
> +		list_add(&req->entry, &queue->send_list);
> +		node = node->next;
> +	}

The if is not needed as the while covers this.

Otherwise this looks good, I'ĺl fix it up when applying.



More information about the Linux-nvme mailing list