[PATCH v2 rfc 1/3] nvme: split nvme_remove_namespaces

Sagi Grimberg sagi at grimberg.me
Wed Jul 22 18:58:11 EDT 2020


>>> I find the split rather confusing.  So I looked into alternatives
>>> and found that the state change should just be a no-op for the PCIe
>>> reset case.
>>
>> Looks like the original version, but the only thing that bothers me
>> is that in the reset handler, if we failed to setup any I/O queues,
>> we'll put the state in DELETING_NOIO while it's not deleting, I think
>> that the point of allowing this is to have the device still up for the
>> user to analyze and debug it.
> 
> Based on the state machine we can't really move from that state to
> DELETING_NOIO as indicated in the comment I added, can we?

You're right. Let me prepare a patch



More information about the Linux-nvme mailing list