[PATCH V3 02/10] nvme-core: use xarray for ctrl ns tracking

Chaitanya Kulkarni Chaitanya.Kulkarni at wdc.com
Wed Jul 15 01:12:10 EDT 2020


On 7/14/20 6:41 PM, Keith Busch wrote:
>>> Since you're using rcu to protect the kref_get() on load, we need a
>>> synchronize_rcu() after removing it from the xarray.
>> No, synchronize_rcu() is expensive.  We should instead use call_rcu()
>> to free the ns once the refcount hits zero.
> Yeah, that is an even better option, though namespace removal is so
> infrequent that cost isn't really a concern: this function already calls
> synchronize_rcu() and syncronize_srcu().
> 

So should keep the synchronize_rcu() ?



More information about the Linux-nvme mailing list