[PATCH v5 08/16] lpfc: vmid: Add support for vmid in mailbox command, does vmid resource allocation and vmid cleanup
kernel test robot
lkp at intel.com
Wed Dec 16 10:13:11 EST 2020
Hi Muneendra,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on scsi/for-next]
[also build test WARNING on mkp-scsi/for-next next-20201215]
[cannot apply to cgroup/for-next v5.10]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Muneendra/blkcg-Support-to-track-FC-storage-blk-io-traffic/20201216-202913
base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/03480ee8b62a90ab2917fccf45d0e56185c1f8a5
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Muneendra/blkcg-Support-to-track-FC-storage-blk-io-traffic/20201216-202913
git checkout 03480ee8b62a90ab2917fccf45d0e56185c1f8a5
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp at intel.com>
All warnings (new ones prefixed by >>):
>> drivers/scsi/lpfc/lpfc_init.c:4288:1: warning: no previous prototype for 'lpfc_vmid_res_alloc' [-Wmissing-prototypes]
4288 | lpfc_vmid_res_alloc(struct lpfc_hba *phba, struct lpfc_vport *vport)
| ^~~~~~~~~~~~~~~~~~~
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for FRAME_POINTER
Depends on DEBUG_KERNEL && (M68K || UML || SUPERH) || ARCH_WANT_FRAME_POINTERS
Selected by
- FAULT_INJECTION_STACKTRACE_FILTER && FAULT_INJECTION_DEBUG_FS && STACKTRACE_SUPPORT && !X86_64 && !MIPS && !PPC && !S390 && !MICROBLAZE && !ARM && !ARC && !X86
vim +/lpfc_vmid_res_alloc +4288 drivers/scsi/lpfc/lpfc_init.c
4275
4276 /**
4277 * lpfc_vmid_res_alloc - Allocates resources for VMID
4278 * @phba: pointer to lpfc hba data structure.
4279 * @vport: pointer to vport data structure
4280 *
4281 * This routine allocated the resources needed for the vmid.
4282 *
4283 * Return codes
4284 * 0 on Succeess
4285 * Non-0 on Failure
4286 */
4287 u8
> 4288 lpfc_vmid_res_alloc(struct lpfc_hba *phba, struct lpfc_vport *vport)
4289 {
4290 u16 i;
4291
4292 /* vmid feature is supported only on SLI4 */
4293 if (phba->sli_rev == LPFC_SLI_REV3) {
4294 phba->cfg_vmid_app_header = 0;
4295 phba->cfg_vmid_priority_tagging = 0;
4296 }
4297
4298 /* if enabled, then allocated the resources */
4299 if (lpfc_is_vmid_enabled(phba)) {
4300 vport->vmid =
4301 kmalloc_array(phba->cfg_max_vmid, sizeof(struct lpfc_vmid),
4302 GFP_KERNEL);
4303 if (!vport->vmid)
4304 return FAILURE;
4305
4306 memset(vport->vmid, 0,
4307 phba->cfg_max_vmid * sizeof(struct lpfc_vmid));
4308
4309 rwlock_init(&vport->vmid_lock);
4310
4311 /* setting the VMID parameters for the vport */
4312 vport->vmid_priority_tagging = phba->cfg_vmid_priority_tagging;
4313 vport->vmid_inactivity_timeout =
4314 phba->cfg_vmid_inactivity_timeout;
4315 vport->max_vmid = phba->cfg_max_vmid;
4316 vport->cur_vmid_cnt = 0;
4317
4318 for (i = 0; i < LPFC_VMID_HASH_SIZE; i++)
4319 vport->hash_table[i] = NULL;
4320
4321 vport->vmid_priority_range = bitmap_zalloc
4322 (LPFC_VMID_MAX_PRIORITY_RANGE, GFP_KERNEL);
4323
4324 if (!vport->vmid_priority_range) {
4325 kfree(vport->vmid);
4326 return FAILURE;
4327 }
4328 }
4329 return 0;
4330 }
4331
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 62883 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-nvme/attachments/20201216/c725a504/attachment-0001.gz>
More information about the Linux-nvme
mailing list