[PATCH] nvme-core: update NS Attr Changed AEN handling for ANA group

[Hannes Reinecke]

On 12/10/20 9:51 AM, hch at lst.de wrote:
> On Wed, Dec 09, 2020 at 01:34:37PM -0800, Keith Busch wrote:
>> Linux hosts currently want an ANA AEN anytime the host needs to refresh
>> the ANA log. That includes any condition that adds groups that didn't
>> exist from the host's previous reading.
>>
>> If the Namespace Attach occurs to an ANA group the host already knows
>> about, then you don't need to send an ANA AEN because there's nothing
>> new in the log that the host requires. You just need to send the NS
>> Notify AEN.
>>
>> But if a side effect of attaching a namespace results in a new ANA group
>> becoming visible to the host, then that group creation is considered a
>> separate event, so the host wants both AENs. I believe this is where
>> Christoph is trying to steer the interpretation and the text.
> 
> Exactly.  Although as Hannes pointed out, this language:
> 
>    If, for an ANA Group, there are no namespaces attached to the
>    controller processing the command, then no ANA Group Descriptor is
>    returned for that ANA Group (i.e., an ANA Group Descriptor is returned
>    only if that ANA Group contains namespaces that are attached to the
>    controller processing the command.
> 
> creates a bit of a chicken an egg problem in that case of a newly
> attached namespace that is the first one referencing an ANA group.
> 
Yes, this was what I tried to outline.

Personally I don't mind whether the controller is required to send an 
ANA change AEN together with the NS change AEN.
Requiring both will pose an ordering issue (as on fabrics we can't 
control the completion ordering), so effectively we'll have to implement 
handling for AENs arriving in any order.
But I'm also fine with just getting one AEN; the patch will solve that 
situation just fine.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare at suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer