[PATCH] nvme: Added QUIRK for Samsung PM1725a

[Christoph Hellwig]

On Wed, Dec 09, 2020 at 04:11:52AM +0900, Keith Busch wrote:
> On Tue, Dec 08, 2020 at 02:54:01PM +0100, Christoph Hellwig wrote:
> > On Tue, Dec 08, 2020 at 08:35:14AM -0500, Gopal Tiwari wrote:
> > > These are two different devices. Only one of the two NVME devices is seen. The other device is rejected  due to “Duplicate cntlid”. 
> > 
> > So two card with one controller each, and both have the same subnqn.
> > Ok.  I guess the quirk is exactly right in this case, although I would
> > not have expected this bug from an enterprise drive from a somewhat
> > reputable vendor.
> 
> And it has CMIC capabilities! The quirk means we're using driver
> generated nqn's for multipath detection, so it won't work with
> multipath: the fake nqn uses the controller serial number, so all the
> controllers in the subsystem will get different nqn's.

SN is uniqueue for the whole subsystem:

"Contains the serial number for the NVM subsystem that isassigned by the
 vendor as an ASCII string."