[PATCH] nvme: retrigger ANA log update if group descriptor isn't found

[Hannes Reinecke]

On 12/7/20 4:34 PM, Christoph Hellwig wrote:
> On Mon, Dec 07, 2020 at 07:31:21AM -0800, Keith Busch wrote:
>> On Sat, Dec 05, 2020 at 04:29:01PM +0100, Hannes Reinecke wrote:
>>> If ANA is enabled but no ANA group descriptor is found when creating
>>> a new namespace the ANA log is most likely out of date, so trigger
>>> a re-read. The namespace will be tagged with the NS_ANA_PENDING flag
>>> to exclude it from path selection until the ANA log has been re-read.
>>>
>>> Reported-by: Martin George <marting at netapp.com>
>>> Signed-off-by: Hannes Reinecke <hare at suse.de>
>>
>> This looks good to me.
>>
>> Reviewed-by: Keith Busch <kbusch at kernel.org>
> 
> But as I just outlined it just papers over buggy controllers.  I really
> don't think we should just silently do that.
> 
What would be the downside of taking this patch?
Personally, I'd rather be lenient and allow to interoperate...

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare at suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer