On Thu, May 17, 2018 at 09:36:58AM -0600, Jens Axboe wrote: > I'd suggest we just move it to the top and get it out of the way instead, > and ensure that the ->cq_vector to -1 includes an mb(). Then we can just > make it: > > if (unlikely(nvmeq->cq_vector < 0)) > return BLK_STS_IOERR; Yes, I like that!