[PATCH 1/3] nvme: remove ->cq_vector == -1 check in nvme_queue_rq()

Keith Busch keith.busch at linux.intel.com
Thu May 17 08:44:31 PDT 2018


On Thu, May 17, 2018 at 09:36:58AM -0600, Jens Axboe wrote:
> I'd suggest we just move it to the top and get it out of the way instead,
> and ensure that the ->cq_vector to -1 includes an mb(). Then we can just
> make it:
> 
> if (unlikely(nvmeq->cq_vector < 0))
>         return BLK_STS_IOERR;

Yes, I like that!



More information about the Linux-nvme mailing list