[PATCH] nvme: handle completions outside of the queue lock

Jens Axboe axboe at kernel.dk
Thu May 17 08:33:34 PDT 2018


On 5/17/18 9:30 AM, Christoph Hellwig wrote:
> On Thu, May 17, 2018 at 08:22:01AM -0600, Jens Axboe wrote:
>> Just apply it on top, doesn't really warrant a rebase imho. But yeah,
>> we should probably cool the jets for a day next time :-)
> 
> Honestly, between the poll issue and things like the volatile
> annotations that should have been a separate prep patch I'd rather
> back out and restart the thing slowly.  We should still have plenty
> of time to get it done for this merge window.

The poll issue is almost moot imho, unless you have a ton of other
IO on the same hardware queue while you poll. It'll work fine, the
testing I ran didn't find anything. Agree the volatile should have
been a prep, but again not really a major thing.

-- 
Jens Axboe




More information about the Linux-nvme mailing list