[PATCH] nvme: remove cq check after submission
Jens Axboe
axboe at kernel.dk
Wed May 16 12:58:08 PDT 2018
We always check the completion queue after submitting, but in my testing
this isn't a win even on DRAM/xpoint devices. In some cases it's
actually worse. Kill it.
Signed-off-by: Jens Axboe <axboe at kernel.dk>
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 17a0190bd88f..79bbfadcb7b9 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -68,7 +68,6 @@ MODULE_PARM_DESC(io_queue_depth, "set io queue depth, should >= 2");
struct nvme_dev;
struct nvme_queue;
-static void nvme_process_cq(struct nvme_queue *nvmeq);
static void nvme_dev_disable(struct nvme_dev *dev, bool shutdown);
/*
@@ -895,7 +894,6 @@ static blk_status_t nvme_queue_rq(struct blk_mq_hw_ctx *hctx,
goto out_cleanup_iod;
}
__nvme_submit_cmd(nvmeq, &cmnd);
- nvme_process_cq(nvmeq);
spin_unlock_irq(&nvmeq->q_lock);
return BLK_STS_OK;
out_cleanup_iod:
--
Jens Axboe
More information about the Linux-nvme
mailing list