[PATCH 1/7] nvme: remove unnecessary controller subnqn validation

Hannes Reinecke hare at suse.de
Mon May 7 22:57:40 PDT 2018


On Mon,  7 May 2018 17:12:08 -0700
"James Smart" <jsmart2021 at gmail.com> wrote:

> After creating the nvme controller, nvmf_create_ctrl() validates
> the newly created subsysnqn vs the one specified by the options.
> 
> In general, this is an unnecessary check as the Connect message
> should implicitly ensure this value matches.
> 
> With the change to the FC transport to do an asynchronous connect
> for the first association create, the transport will return to
> nvmf_create_ctrl() before that first association has been established,
> thus the subnqn will not yet be set.
> 
> Remove the unnecessary validation.
> 
> Signed-off-by: James Smart <james.smart at broadcom.com>
> ---
>  drivers/nvme/host/fabrics.c | 10 ----------
>  1 file changed, 10 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare at suse.com>

Cheers,

Hannes





More information about the Linux-nvme mailing list