[PATCH 2/3] nvme-pci: Remove unused queue parameter

Keith Busch keith.busch at intel.com
Mon Mar 26 07:48:09 PDT 2018


On Mon, Mar 26, 2018 at 09:47:07AM +0800, Ming Lei wrote:
> On Fri, Mar 23, 2018 at 04:19:22PM -0600, Keith Busch wrote:
> > @@ -1629,9 +1627,7 @@ static int nvme_create_io_queues(struct nvme_dev *dev)
> >  	int ret = 0;
> >  
> >  	for (i = dev->ctrl.queue_count; i <= dev->max_qid; i++) {
> > -		/* vector == qid - 1, match nvme_create_queue */
> > -		if (nvme_alloc_queue(dev, i, dev->q_depth,
> > -		     pci_irq_get_node(to_pci_dev(dev->dev), i - 1))) {
> > +		if (nvme_alloc_queue(dev, i, dev->q_depth)) {
> >  			ret = -ENOMEM;
> >  			break;
> >  		}
> 
> nvme_create_io_queues() is called after pci_alloc_irq_vectors() returns,
> and the above pci_irq_get_node() should return the correct node info,
> right?

Right, the return is correct. It's just not being used anymore.



More information about the Linux-nvme mailing list