[PATCH] nvme-fabrics: Ignore nr_io_queues option for discovery controllers

James Smart james.smart at broadcom.com
Fri Mar 2 10:02:22 PST 2018


On 3/2/2018 9:45 AM, Roland Dreier wrote:
> @@ -650,6 +650,11 @@ static int nvmf_parse_options(struct nvmf_ctrl_options *opts,
>   				ret = -EINVAL;
>   				goto out;
>   			}
> +			if (opts->discovery_nqn) {
> +				pr_warn("Ignoring nr_io_queues value for discovery controller\n");
> +				break;
> +			}
> +
>   			opts->nr_io_queues = min_t(unsigned int,
>   					num_online_cpus(), token);
>   			break;

a pr_warn is a bit verbose. even a pr_warn is. I'd prefer no message at 
all as it's normal for a discovery controller.

-- james




More information about the Linux-nvme mailing list