[PATCH] nvme: change order of qid and cmdid in completion trace

Jens Axboe axboe at kernel.dk
Thu Apr 26 13:01:59 PDT 2018


On 4/26/18 1:49 PM, Johannes Thumshirn wrote:
> Keith reported that command submission and command completion
> tracepoints have the order of the cmdid and qid fileds swapped.
> 
> While it isn't easily possible to change the command submission
> tracepoint, as there is a regression test parsing it in blktests we
> can swap the command completion tracepoint to have the fileds aligned.

It also makes more sense to have qid before cmdid.

Also, fileds -> fields, in two spots.

With that:

Reviewed-by: Jens Axboe <axboe at kernel.dk>

-- 
Jens Axboe




More information about the Linux-nvme mailing list