[PATCH] nvme: Fix disk names when not using nvme multipath

Christoph Hellwig hch at lst.de
Thu Apr 19 01:50:01 PDT 2018


On Wed, Apr 18, 2018 at 10:09:42AM -0600, Keith Busch wrote:
> On Wed, Apr 18, 2018 at 05:34:45PM +0200, Christoph Hellwig wrote:
> > True.  We should do that anyway.  I'll turn this into a real series
> > with a few more final touches tomorrow.
> 
> I started this before I saw your message:

Even better :)

>  static bool multipath = true;
> -module_param(multipath, bool, 0644);
> +module_param(multipath, bool, 0444);
>  MODULE_PARM_DESC(multipath,

I think this part should be split into a separate patch as it's already
unsafe.

Otherwise this looks ok to me, but I wonder if the helper is really
worth the effort.



More information about the Linux-nvme mailing list