[RFC PATCH 8/8] nvmet: add configfs interface for target passthru

Logan Gunthorpe logang at deltatee.com
Fri Apr 13 10:37:16 PDT 2018



On 13/04/18 11:30 AM, Christoph Hellwig wrote:
> Maybe.  But how would you design it?  Have a passthrough filed under
> the subsystem that you can echo a controller name to?  And then make
> the exclusive vs creating namespaces?

Yes. It only really requires one field (the path to the nvme char
device) and making it exclusive to namespaces doesn't seem that
unintuitive. An error and appropriate dmesg if one is set before the
other would be pretty clear and quickly understood (compared to a whole
new top level directory named 'pt'). When I'm playing around with
sysfs/configfs/debugfs interfaces I rarely read the documentation and
just watch dmesg if I see an error returned. When I first played around
with this patchset the current interface required me to look at the code
to understand what was going on (there was no documentation).

> Ugg.  Hell no!  Way too much magic.

Fair point.

Logan



More information about the Linux-nvme mailing list