[REPOST PATCH] nvmet: Fix fatal_err_work deadlock

Hannes Reinecke hare at suse.de
Fri Oct 20 07:11:15 PDT 2017


On 10/20/2017 12:27 PM, Christoph Hellwig wrote:
> Why can't we just switch to flush_work instead of cancel_work_sync?
> 
> fatal_err_work never requeues itself, although we might need
> protection against queueing more up once we enter nvmet_ctrl_free.
> 
That's actually what I would prefer, too.

Deadlocking when doing to final put on the controller from the
fatal_error queue function is not a nice design.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare at suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)



More information about the Linux-nvme mailing list