[PATCH 4.14-rc] nvme-rdma: Fix error status return in tagset allocation failure
Christoph Hellwig
hch at lst.de
Thu Oct 19 01:49:26 PDT 2017
> if (new) {
> ctrl->ctrl.admin_tagset = nvme_rdma_alloc_tagset(&ctrl->ctrl, true);
> - if (IS_ERR(ctrl->ctrl.admin_tagset))
> + if (IS_ERR(ctrl->ctrl.admin_tagset)) {
> + error = PTR_ERR(ctrl->ctrl.admin_tagset);
> goto out_free_queue;
> + }
Can we return an error code instead and just pass in the tag set
to be allocated instead of the admin flag?A E.g.:
error = nvme_rdma_alloc_tagset(&ctrl->ctrl, &ctrl->ctrl.admin_tagset);
if (error)
goto out_free_queue;
More information about the Linux-nvme
mailing list