[PATCH 5/7] nvmet: implement namespace identify descriptor list

[Johannes Thumshirn]

On 05/30/2017 01:04 PM, Max Gurtovoy wrote:
>> +static void nvmet_execute_identify_desclist(struct nvmet_req *req)
>> +{
>> +    static const int buf_size = 4069;
> 
> Shouldn't it be 4096 ?
> 

Good catch, thanks. Should probably change all to SZ_4K.

[...]

>> +    if (memchr_inv(ns->uuid, 0, sizeof(ns->uuid))) {
>> +        ns_nid = (struct nvme_ns_nid *)p;
>> +        ns_nid->nidt = NVME_NIDT_UUID;
>> +        ns_nid->nidl = 16;
> 
> maybe define NVME_NIDT_UUID_LEN instead of 16 ?
> this way you can use it in the host side too.
> 

Good point, will do in v2.


-- 
Johannes Thumshirn                                          Storage
jthumshirn at suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850