[PATCH] lightnvm: Remove an unused variable

Jens Axboe axboe at fb.com
Tue May 9 07:50:17 PDT 2017


On 05/09/2017 04:19 AM, Javier González wrote:
>> On 9 May 2017, at 11.34, Dan Carpenter <dan.carpenter at oracle.com> wrote:
>>
>> "rq" is never used in nvme_nvm_rqtocmd().  We also recently shifted some
>> code around so it's uninitialized and causes a static checker warning.
>> Let's just remove it.
>>
> 
> Looks good. I didn't see it when I refactored that part.
> Matias: If it is ok with you, can you pick it up?
> 
> Reviewed-by: Javier González <javier at cnexlabs.com>

Geert sent in a similar fix two days ago, it's already queued up:

commit 629b1b2e0e6c8285fdc21624af60e8190fa4417e
Author: Geert Uytterhoeven <geert at linux-m68k.org>
Date:   Sun May 7 16:14:44 2017 +0200

    lightnvm: remove unused rq parameter of nvme_nvm_rqtocmd() to kill warning

-- 
Jens Axboe




More information about the Linux-nvme mailing list