[PATCH] nvmet: release the sq ref on rdma read errors

[Christoph Hellwig]

On Thu, May 04, 2017 at 08:50:56AM +0300, Sagi Grimberg wrote:
> While it is true that we need to drop the reference on
> the nvmet_sq, there is no point in queuing a response
> message because the rdma qp is in error state and the response
> will never make it to the host.

Yeah.

> I think we should explicitly drop the sq reference and release
> the rsp and avoid triggering the TX path, and provide a detailed
> comment on why we are doing this. Maybe a nicer way to do this,
> is to introduce a nvme_req_uninit() that would take care of
> it in the right layer (that is nvmet core).

Agreed.