This looks fine to me: Reviewed-by: Christoph Hellwig <hch at lst.de> Btw, we really should do something about the global format behavior bits in FNA - if bit 0 or 1 are set we should fail formats that are specific to a namespace and not global with a warnings.