[PATCH] nvmet-rdma: Fix a possible uninitialized variable dereference

Sagi Grimberg sagi at grimberg.me
Mon Mar 13 04:08:07 PDT 2017



On 13/03/17 13:05, Sagi Grimberg wrote:
> When handling a new recv command, we grab a new rsp resource and
> check for the queue state being live. In case the queue is not in
> live state, we simply restore the rsp back to the free list. However
> in this flow we didn't set rsp->queue yet, so we cannot dereference it.
>
> Instead, get rid of rsp->queue, because we already have rsp->cmd
> reference which has a queue reference already, so use that instead.
>
> Signed-off-by: Sagi Grimberg <sagi at grimberg.me>

This is missing of course:

Reported-by: Yi Zhang <yizhan at redhat.com>
Reported-by: Raju Rangoju <rajur at chelsio.com>

Thanks Yi and Raju for reporting.

Please let us know if we can add your "Tested-by" tag.



More information about the Linux-nvme mailing list