[PATCH] lpfc: Finalize Kconfig options for nvme

Christoph Hellwig hch at infradead.org
Tue Mar 7 13:23:51 PST 2017


> +#if defined(CONFIG_NVME_FC)
> +#define CONFIG_LPFC_NVME_INITIATOR
> +#endif
> +
> +#if defined(CONFIG_NVME_TARGET_FC)
> +#define CONFIG_LPFC_NVME_TARGET
> +#endif

The CONFIG_* namespace is reserved for Kconfig defined symbols.

Also I think the above is wrong if the nvme fc core code is built
modular.  I think you want to replace all occurances of

#ifdef CONFIG_LPFC_NVME_INITIATOR

with

if (IS_ENABLED(CONFIG_NVME_FC))

and vice versa for the taget.



More information about the Linux-nvme mailing list