[PATCHv2] nvme: Remove SCSI translations

Elliott, Robert (Persistent Memory) elliott at hpe.com
Fri Jun 30 05:44:11 PDT 2017


> Subject: [PATCHv2] nvme: Remove SCSI translations
> 
> The SCSI-to-NVMe translations were added to assist storage applications
> utilizing SG_IO transitioning to NVMe. It was always recommended,
> however, to use native NVMe for device management as too much is lost
> in translation and the maintenance burden in keeping this kludgey
> layer around has been neglected such that much of the translations are
> completely broken.
> 
> This patch removes SG_IO handling from NVMe to avoid any confusion
> regarding maintenance support for this interface. The config option for
> NVMe SCSI emulation has been disabled by default since 4.5. The driver
> has supported native nvme user commands since the beginning, and native
> tooling is publicly available for use or as reference for anyone writing
> their own tools, so there's no excuse for hanging onto a broken crutch.

As Linda and Micah mentioned, this violates a cardinal linux kernel rule -
it breaks user space.

Please:
1. Incorporate the TEST UNIT READY bug fix now.
2. Add a WARN_ONCE printing a message that the interface that was just
used is deprecated and will go away, and modify the CONFIG description
to include that warning too.
3. Wait a few kernel cycles before really removing it.


---
Robert Elliott, HPE Persistent Memory






More information about the Linux-nvme mailing list