[PATCH 1/4] nvme-cli : add support for sanitize command.

Keith Busch keith.busch at intel.com
Thu Jun 29 10:43:21 PDT 2017


On Thu, Jun 29, 2017 at 12:44:43PM -0400, Keith Busch wrote:
> On Wed, Jun 28, 2017 at 07:19:25PM -0700, Chaitanya Kulkarni wrote:
> > +	const struct argconfig_commandline_options command_line_options[] = {
> > +		{"no_dealloc", 'd', "", CFG_NONE, &cfg.no_dealloc, no_argument, no_dealloc_desc},
> 
> Just a minor request, this tool uses '-' instead of '_' for compound
> word long options, and I think keeping that consistency is a good thing.

Ah, it was just this one that used '_'. The documentation used '-'
already. I made the fix in this patch and applied all of them.

Thanks!



More information about the Linux-nvme mailing list