[PATCH nvme-cli] fabrics: add hostid option to connect command

[Johannes Thumshirn]

On Tue, Jun 20, 2017 at 02:31:02PM +0200, Christoph Hellwig wrote:
> On Tue, Jun 20, 2017 at 02:25:56PM +0200, Johannes Thumshirn wrote:
> > Add an option to pass in the hostid either via command line or a new config
> > file /etc/nvme/hostid.
> 
> Looks great!
> 
> Reviewed-by: Christoph Hellwig <hch at lst.de>
> 
> I think we should also add code to generate a default hostid somewhere.
> I guess we could just uuidgen(1) and drive it from the package?  Sagi
> added a call to genhostnqn to the specfile, so that should go into
> it as well.

sth like:

%postin
uuidgen > /etc/nvme/hostid

should do the trick methinks.

> (and it seems like Debian packaging isn't present at all in the
> package)

Aren't you a Debian user ;-)

-- 
Johannes Thumshirn                                          Storage
jthumshirn at suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850