[PATCH v5 for-4.13 3/7] mlx5: move affinity hints assignments to generic code

Sagi Grimberg sagi at grimberg.me
Sun Jun 18 01:02:17 PDT 2017


>>   	rq->mpwqe.info = kzalloc_node(wq_sz * sizeof(*rq->mpwqe.info),
>> -				      GFP_KERNEL, cpu_to_node(c->cpu));
>> +					GFP_KERNEL, node);
> 
> Why the reindenting?

Heh, no good reason, I'm just a tabs person...

Although I might consider converting :)
https://www.theregister.co.uk/2017/06/16/spaces_vs_tabs/

> 
>>   	/* We allocate more than mtt_sz as we will align the pointer */
>> -	rq->mpwqe.mtt_no_align = kzalloc_node(mtt_alloc * wq_sz, GFP_KERNEL,
>> -					cpu_to_node(c->cpu));
>> +	rq->mpwqe.mtt_no_align = kzalloc_node(mtt_alloc * wq_sz,
>> +					GFP_KERNEL, node);
> 
> Or the moving of GFP_KERNEL to the next line here?

I'll respin...



More information about the Linux-nvme mailing list