[PATCH] nvme: submit nvme_admin_activate_fw to admin queue

Sagi Grimberg sagi at grimberg.me
Thu Jun 15 02:15:05 PDT 2017



On 14/06/17 09:27, Christoph Hellwig wrote:
> On Tue, Jun 13, 2017 at 04:36:50PM -0500, David Milburn wrote:
>> The nvme_admin_activate_fw command should be submitted to
>> the admin queue; otherwise, mode 0x0F (ACTIVATE_DEFERRED_MICROCODE)
>> and mode 0x05 (DOWNLOAD_SAVE_ACTIVATE) will fail.
>>
>> Fixes: b90c48d0c11ef("nvme: split nvme_trans_send_fw_cmd")
>> Reported-by: Joseph Szczypek <joseph.szczypek at hpe.com>
>> Tested-by: Micah Parrish <micah.parrish at hpe.com>
>> Signed-off-by: David Milburn <dmilburn at redhat.com>
> 
> If this command has been broken all the time we should just remove it.

Agreed.



More information about the Linux-nvme mailing list