[PATCH] nvme: move protection information check into nvme_setup_rw

Johannes Thumshirn jthumshirn at suse.de
Tue Jun 13 01:00:23 PDT 2017


On 06/12/2017 06:36 PM, Christoph Hellwig wrote:
> +static inline blk_status_t nvme_setup_rw(struct nvme_ns *ns,
> +		struct request *req, struct nvme_command *cmnd)
>  {

Hmm here you're changing nvme_setup_rw to return blk_status_t

[...]

> @@ -386,6 +395,7 @@ static inline void nvme_setup_rw(struct nvme_ns *ns, struct request *req,
>  
>  	cmnd->rw.control = cpu_to_le16(control);
>  	cmnd->rw.dsmgmt = cpu_to_le32(dsmgmt);
> +	return 0;
>  }

And here you're returning 0 instead of BLK_STATUS_OK.

Intentional?

-- 
Johannes Thumshirn                                          Storage
jthumshirn at suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850



More information about the Linux-nvme mailing list