[PATCH 3/3] nvme: wwid_show: copy hex string verbatim

Christoph Hellwig hch at lst.de
Sat Jul 15 01:46:03 PDT 2017


On Fri, Jul 14, 2017 at 09:40:57PM +0200, Martin Wilck wrote:
> > True.  Although that only really is a fix for buggy controllers,
> > and should not affect the PCIe controllers (for which a compliance
> > test for this exists, unfortunately that doesn't work for fabrics).
> 
> Is that a NAK, or not?

That's an ACK for the null vs whitespace changes.  The NAK
for this patch still stands.

> "We will"? People are (trying to) use NVMe with multipath today, and
> they use dm-multipath and multipathd for that. Maybe that'll change
> some day, but not too soon, I believe.

Who are these people and why aren't they on the nvme list?  The
dm-mpath approach is fundamentally wrong for NVMe, and especially
NVMeOF - e.g. for NVMeOF we have the mandatory keep alive, so doing
any wonky path checking from userspace is just going to create
problems.



More information about the Linux-nvme mailing list