[PATCH v2 2/2] nvmet: preserve controller serial number between reboots
Johannes Thumshirn
jthumshirn at suse.de
Fri Jul 14 05:46:32 PDT 2017
On Fri, Jul 14, 2017 at 02:32:08PM +0200, Christoph Hellwig wrote:
> This patch itself looks good:
>
> Reviewed-by: Christoph Hellwig <hch at lst.de>
>
> > static struct configfs_attribute *nvmet_subsys_attrs[] = {
> > &nvmet_subsys_attr_attr_allow_any_host,
> > &nvmet_subsys_attr_version,
> > + &nvmet_subsys_attr_attr_serial,
>
> but the new version attribute really needs the attr prefix so that
> nvmetcli can pick it up. And we should also add nvmetcli support
> for it. Can you do the rename before your series to ease backporting
> as that should go into 3.12 (just like your serial number fix).
>
Is it OK if I send the patches in the same series?
--
Johannes Thumshirn Storage
jthumshirn at suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
More information about the Linux-nvme
mailing list