[PATCH] nvme-pci: add module parameter for io queue depth

weiping zhang zhangweiping at didichuxing.com
Mon Jul 10 01:02:23 PDT 2017


On Mon, Jul 10, 2017 at 08:54:57AM +0300, Sagi Grimberg wrote:
> 
> >>+static int io_queue_depth = 1024;
> >>+module_param(io_queue_depth, int, 0644);
> >>+MODULE_PARM_DESC(io_queue_depth, "set io queue depth");
> >We need to be a little more careful about this field if users can write
> >whatever they want. It's gotta be >= 2 or else trouble will occur.
> 
> Agreed, please resend the patch. Perhaps a good way is to use
> module_param_cb() to verify the input value is >= 2?

thanks so much, I will send patch v3.



More information about the Linux-nvme mailing list