[PATCH v2] nvme-fabrics: Prevent KATO to be set as 0

[Guilherme G. Piccoli]

On 08/30/2017 06:55 AM, Sagi Grimberg wrote:
> 
>> Since the debug feature of setting KATO to 0 is not working
>> anymore, remove it from code. If user sets it to 0, default
>> value will be explicitly used.
> 
> Why not allowing it? its pretty useful for testing.
> 

Okay, so I misinterpreted your last message.

My understanding was that since the condition was added in some point of
time, the possibility of KATO being set to 0 was "indirectly" dropped
and your suggestion was to _drop it officially_.

My bad...

So, please clarify it to me: do we want to allow a 0 value for KATO? If
yes, no piece of code is needed in the target to stop sending keep alives?
The way it "works" today (aka my 1st patch), if we set KATO as 0, we get
timeout right after connection. When I first set KATO to 0 in my debug,
I was expecting to disable keep alives, not getting timeouts heheh


So, the purpose of KATO == 0 is to:

(a) Get timeouts right after the connection is complete and keep getting
them forever? Or...

(b) Disable keep alives at all? (and in this case, we need to inform the
target to not send keep alives in case of a 0 valued kato).

Thanks in advance,


Guilherme