[PATCH V3] nvmet: Add support for HOST_ID feature.

Christoph Hellwig hch at infradead.org
Tue Aug 29 07:49:15 PDT 2017


> +	case NVME_FEAT_HOST_ID:
> +		if (!(le32_to_cpu(req->cmd->common.cdw10[1]) & 1))
> +			status = NVME_SC_INVALID_FIELD | NVME_SC_DNR;
> +		else
> +			status = nvmet_copy_to_sgl(req, 0,
> +					&req->sq->ctrl->hostid, 16);
> +		break;

The 16 here should be a sizeof(uuid_t) or sizeof(req->sq->ctrl->hostid),
but we can fix this up when applying the patch.

Looks good,

Reviewed-by: Christoph Hellwig <hch at lst.de>



More information about the Linux-nvme mailing list