[PATCH 1/2] nvme: Fix nvme reset command timeout handling

Christoph Hellwig hch at lst.de
Thu Aug 10 01:38:27 PDT 2017


On Fri, Jul 28, 2017 at 09:58:34AM +0200, Johannes Thumshirn wrote:
> On Thu, Jul 27, 2017 at 12:58:40PM -0400, Keith Busch wrote:
> >  static void nvme_set_latency_tolerance(struct device *dev, s32 val)
> > @@ -1856,17 +1857,25 @@ int nvme_init_identify(struct nvme_ctrl *ctrl)
> >  
> >  	kfree(id);
> >  
> > +	if (ret < 0)
> > +		return ret;
> > +
> 
> This is a bit confusing IMHO, how about this?

Agreed.

We probably should get this series into 4.13, so other comments would
be welcome.



More information about the Linux-nvme mailing list