[PATCH 2/2] lpfc: support nvmet_fc defer_rcv callback
James Smart
jsmart2021 at gmail.com
Wed Aug 2 07:32:36 PDT 2017
On 8/2/2017 1:32 AM, Johannes Thumshirn wrote:
>> len += snprintf(buf+len, PAGE_SIZE-len,
>> - "FCP: Rcv %08x Release %08x Drop %08x\n",
>> + "FCP: Rcv %08x Defer %08x Release %08x "
>> + "Drop %08x\n",
>
> Please don't split the string across lines, it makes grepping hard.
> Checkpatch actually warns you about that.
The indentation and length of the string exceeds the 80 chararacters. so
has to be split. lpfc is littered with this in the debug path. It'll be
one of the things we address in the efct refactoring. For now, this
style has been grandfathered in.
-- james
More information about the Linux-nvme
mailing list