[PATCH 1/1] nvme : Add sysfs entry for NVMe CMBs when appropriate

[J Freyensee]

On Wed, 2016-10-05 at 11:48 -0600, Stephen Bates wrote:
> On Wed, Oct 05, 2016 at 07:50:57PM +0300, Sagi Grimberg wrote:
> > 
> > 
> > > 
> > > The fabrics specification currently denotes the CMBLOC and CMBSZ
> > > properties as reserved [1].
> > 
> > Managed to forget that... So I guess I'm fine with the patch as
> > it is,
> > 
> > Reviewed-by: Sagi Grimberg <sagi at grimberg.me>
> > 
> 
> Sagi
> 
> Thanks! I will work on a v1 to address Jonathan's issue and add your
> tag to that. Coming soon...

You can add my tag too if you like as well, as I've chatted my thoughts
to you via phone/email:

Reviewed-by: Jay Freyensee <james_p_freyensee at linux.intel.com>


> 
> > 
> > > 
> > > Also I am wondering where the physical memory backing a fabrics
> > > CMB
> > > would reside. Would this be memory in the fabric NIC on the host,
> > > in
> > > the NIC on the target or somewhere else?
> > 
> > This was discussed in the WG a few times before, not sure if we
> > can discuss this before its in the spec though...
> 
> Ooops, you are correct. Us lowely kernel developers should not be
> discussing things related to changes to the NVMe specification ;-). I
> will take this discussion inside the NVMe technical working group.
> 
> Cheers
> 
> Stephen
> 
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme