[PATCH 2/5] block: add support for REQ_OP_WRITE_ZEROES

chaitany kulkarni ckulkarnilinux at gmail.com
Thu Nov 17 14:28:12 PST 2016


Incorporated the comments and sent new patch.

On Wed, Nov 16, 2016 at 6:48 PM, Martin K. Petersen
<martin.petersen at oracle.com> wrote:
>>>>>> "Keith" == Keith Busch <keith.busch at intel.com> writes:
>
> Keith> Your maximum bi_size exceeds the 2-bytes an NVMe Write Zeroes
> Keith> command provides for the block count. Instead of having a simple
> Keith> queue flag for write zeroes support, have it take a max sectors
> Keith> value instead.
>
> Yes, please. Make it a queue limit and make sure it is properly stacked.
>
> The rest looks sensible to me. I'll wire up the SCSI pieces.
>
> --
> Martin K. Petersen      Oracle Linux Engineering



More information about the Linux-nvme mailing list