[PATCH] nvmet-rdma: add queue to queue list only if connection established

Sagi Grimberg sagi at grimberg.me
Sun Nov 6 09:19:58 PST 2016


>> In case we accepted a queue connection and it failed, we might not
>> remove the queue from the list. Instead of dealing with it, simply
>> add the insert the queue only if we successfully established.
>
> But that means we'd potentionally leak it when unloading the module,
> if that happens at just the wrong time, don't we?

Yea... didn't think of that. I started with removing from the list on
connect failure too but thought this would be better...

I'll reverse the strategy again...



More information about the Linux-nvme mailing list