[PATCH RFC] nvme: rewrite discard support

Keith Busch keith.busch at intel.com
Mon Mar 21 08:51:39 PDT 2016


On Mon, Mar 21, 2016 at 03:47:59PM +0100, Christoph Hellwig wrote:
> I think we should just do a 16 byte (or rather cache line size) kmalloc,
> as there is no need for a mempool for discards.  Would a version of
> that be fine with you?  Because discard is currently the only thing
> preventing us from having a split between transport and commanset specific
> setup for NVMe.  And as things like Fabrics and LighNVM show I think
> a clean split there would be rather benefitical in the long run.

We only used the mempool for the driver to leverage normal IO clean up
so that discard isn't special.

It looks like SCSI's special handling lead to what the code comments
describe as a "horrible hack", so that's not convincing this is a good
example to follow.



More information about the Linux-nvme mailing list